provider: adding a test ensuring that Data Sources do not support import #23820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't possible for Data Sources, therefore Data Sources shouldn't be defining an `Importer`
This isn't supported for Data Sources so is invalid
This isn't valid for a data source
This isn't valid for Data Sources, so should be removed
github-actions
bot
added
service/kusto
service/data-protection
service/network
size/S
labels
tombuildsstuff
deleted the
b/schema-data-sources-cannot-support-import
branch
tombuildsstuff
added a commit
that referenced
this pull request
Nov 8, 2023
dduportal
pushed a commit
to jenkins-infra/azure
that referenced
this pull request
Nov 10, 2023
<Actions>
<action
id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8">
<h3>Bump Terraform `azurerm` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
<summary>Update Terraform lock file</summary>
<p>"hashicorp/azurerm" updated from "3.79.0" to
"3.80.0" in file ".terraform.lock.hcl"</p>
<details>
<summary>3.80.0</summary>
<pre>Changelog retrieved
from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.80.0
ENHANCEMENTS:

*
`internal/sdk` - Added support for pointer Types in resource models
([#23810](hashicorp/terraform-provider-azurerm#23810
dependencies: updating to `v0.63.0` of
`github.com/hashicorp/go-azure-helpers`
([#23785](hashicorp/terraform-provider-azurerm#23785
dependencies: updating to `v0.20231106.1151347` of
`github.com/hashicorp/go-azure-sdk`
([#23787](hashicorp/terraform-provider-azurerm#23787
`azurerm_cognitive_deployment` - support for the
`version_upgrade_option` property
([#22520](hashicorp/terraform-provider-azurerm#22520
`azurerm_firewall_policy_rule_collection_group` - add support for the
property `http_headers`
([#23641](hashicorp/terraform-provider-azurerm#23641
`azurerm_kubernetes_cluster` - `fips_enabled` can be updated in the
`default_node_pool` without recreating the cluster
([#23612](hashicorp/terraform-provider-azurerm#23612
`azurerm_kusto_cluster` - the cluster `name` can now include dashes
([#23790](hashicorp/terraform-provider-azurerm#23790
`azurerm_postgresql_database` - update the validation of `collation` to
include support for `French_France.1252`
([#23783](https://github.com/hashicorp/terraform-provider-azurerm/issues/23783))

BUG
FIXES:

* Data Source: `azurerm_data_protection_backup_vault` -
removing `import` support, since Data Sources don't support being
imported
([#23820](hashicorp/terraform-provider-azurerm#23820
Data Source: `azurerm_kusto_database` - removing `import` support, since
Data Sources don't support being imported
([#23820](hashicorp/terraform-provider-azurerm#23820
Data Source: `azurerm_virtual_hub_route_table` - removing `import`
support, since Data Sources don't support being imported
([#23820](https://github.com/hashicorp/terraform-provider-azurerm/issues/23820))


</pre>
</details>
</details>
</action>
</Actions>
---
<table>
<tr>
<td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
</td>
<td>
<p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
</p>
<details><summary>Options:</summary>
<br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
<ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
</ul>
<p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
</p>
</details>
</td>
</tr>
</table>
Co-authored-by: Jenkins Infra Bot (updatecli) <[email protected]>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue spotted where 3 data sources incorrectly define
importfunctions, which aren't valid - so these aren't usable by first adding a test to detect the issue and then removing theimporterfunctions as needed.