Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to disable public_network_access in azurerm_bot_service_azure_bot #23572

Closed
1 task done
DennisLundtoft opened this issue Oct 16, 2023 · 6 comments
Closed
1 task done

Comments

@DennisLundtoft
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment and review the contribution guide to help.

Description

Add support to disable public_network_access in azurerm_bot_service_azure_bot
azurerm_bot_service_azure_bot seem to be missing the property to disable public network access. It seems to be supported in the SDK

New or Affected Resource(s)/Data Source(s)

azurerm_bot_service_azure_bot

Potential Terraform Configuration

resource "azurerm_bot_service_azure_bot" "example" {
  name                = "examplebot"
  resource_group_name = var.resource_group_name
  location            = var.location
  microsoft_app_id    = var.client_id
  sku                 = "F0"

  public_network_access_enabled = false
}

References

No response

@rcskosir
Copy link
Contributor

@DennisLundtoft Thank you for taking the time to open this feature request!

@neil-yechenwei
Copy link
Contributor

Thanks for raising this issue. I assume it has been supported by TF. See more details from https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/bot_channels_registration.html#public_network_access_enabled.

@jake-setford
Copy link

Thanks for raising this issue. I assume it has been supported by TF. See more details from https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/bot_channels_registration.html#public_network_access_enabled.

@neil-yechenwei thats for the old deprecated azurerm_bot_channels_registration @DennisLundtoft is talking about the latest offering azurerm_bot_service_azure_bot. I'm currently migrating a number of bots and have just hit this issue.

@drdamour
Copy link
Contributor

looks like this was attempted to be added in #24125 but seems to be broken on a refresh...TF always determines the value is false for our bots

@rcskosir
Copy link
Contributor

@drdamour Thank you for helping find the connecting PR. I am going to mark this issue as resolved with #24125 since the enhancement support was added with that PR. I have labeled your issue #24242 as a bug and work to fix it can be tracked via that issue. Thank you again for the help.

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants