Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_managed_disk - upgrade API from 2022-03-02 to 2023-04-02 #23233

Merged
merged 2 commits into from
Sep 11, 2023
Merged

azurerm_managed_disk - upgrade API from 2022-03-02 to 2023-04-02 #23233

merged 2 commits into from
Sep 11, 2023

Conversation

ms-zhenhua
Copy link
Contributor

Upgrade API version to support newly added properties: (new properties will be in another PR)

@tombuildsstuff tombuildsstuff mentioned this pull request Sep 11, 2023
Merged
tombuildsstuff
tombuildsstuff approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff
Copy link
Contributor

@ms-zhenhua mind rebasing this PR/running go mod tidy && go mod vendor?

@ms-zhenhua
Copy link
Contributor Author

@ms-zhenhua mind rebasing this PR/running go mod tidy && go mod vendor?

@tombuildsstuff, thank you for your review. I am fixing the 2 failed checks. For Check for new usages of deprecated functionality, it's caused by the existing code. Do I need to change current logic of the DELETE function by removing the code of d.Get ? Or is there a way to skip the error caused by existing code?

@tombuildsstuff tombuildsstuff force-pushed the upgrade-compute-disk-api branch from 0d85545 to df1672c Compare September 11, 2023 14:25
@tombuildsstuff
Copy link
Contributor

Rebased atop main

@tombuildsstuff tombuildsstuff added this to the v3.73.0 milestone Sep 11, 2023
@tombuildsstuff tombuildsstuff merged commit 384d2b5 into hashicorp:main Sep 11, 2023
19 of 20 checks passed
tombuildsstuff added a commit that referenced this pull request Sep 11, 2023
@tombuildsstuff
updating to include #23233
a40704c
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
dependencies service/data-protection service/disks service/recovery-services size/L state-migration waiting-response
Projects
None yet
Milestone
v3.73.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ms-zhenhua @tombuildsstuff