Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_bot_channel_direct_line_speech - support for cognitive_service_id #23106

Merged
merged 5 commits into from
Sep 6, 2023
Merged

azurerm_bot_channel_direct_line_speech - support for cognitive_service_id #23106

merged 5 commits into from
Sep 6, 2023

Conversation

neil-yechenwei
Copy link
Contributor

@neil-yechenwei neil-yechenwei commented Aug 29, 2023 •
edited
Loading

--- PASS: TestAccBotChannelsRegistration/channel/directLineSpeechRequiresImport (394.91s)
--- PASS: TestAccBotChannelsRegistration/channel/directLineSpeechUpdate (810.79s)
--- PASS: TestAccBotChannelsRegistration/channel/directLineSpeechComplete (383.09s)
--- PASS: TestAccBotChannelsRegistration/channel/directLineSpeechBasic (449.11s)

@neil-yechenwei
Copy link
Contributor Author

@stephybun & @tombuildsstuff , thanks for the comments. I updated PR. Please take another look. Thanks.

stephybun
stephybun requested changes Sep 5, 2023
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neil-yechenwei, I missed something in the initial review. I think we also need to test the update of this value, so can you please add the property to the update config for the tests?

internal/services/bot/bot_channel_direct_line_speech_resource.go Outdated Show resolved Hide resolved
@neil-yechenwei
Copy link
Contributor Author

@stephybun , thanks for the comments. I updated PR. Please take another look. Thanks.

stephybun
stephybun approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neil-yechenwei LGTM 👍

@stephybun stephybun merged commit b34ccad into hashicorp:main Sep 6, 2023
23 checks passed
@github-actions github-actions bot added this to the v3.72.0 milestone Sep 6, 2023
stephybun added a commit that referenced this pull request Sep 7, 2023
@stephybun
Update for #23146 #23124 #23096 #22906 #23160 #23106 #22709
3abf2e4
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephybun stephybun stephybun approved these changes

@tombuildsstuff tombuildsstuff Awaiting requested review from tombuildsstuff

Assignees
No one assigned
Labels
documentation enhancement service/bots size/XS
Projects
None yet
Milestone
v3.72.0
Development

Successfully merging this pull request may close these issues.
3 participants
@neil-yechenwei @tombuildsstuff @stephybun