new resource azurerm_resource_management_private_link

[teowa]

Resource management private link (Microsoft.Authorization/resourceManagementPrivateLinks)

TF_ACC=1 go test -v ./internal/services/resource -parallel 20 -run TestAccResourceManagementPrivateLink -timeout 2h -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccResourceManagementPrivateLink_basic
=== PAUSE TestAccResourceManagementPrivateLink_basic
=== RUN   TestAccResourceManagementPrivateLink_requiresImport
=== PAUSE TestAccResourceManagementPrivateLink_requiresImport
=== CONT  TestAccResourceManagementPrivateLink_basic
=== CONT  TestAccResourceManagementPrivateLink_requiresImport
--- PASS: TestAccResourceManagementPrivateLink_requiresImport (120.34s)
--- PASS: TestAccResourceManagementPrivateLink_basic (123.63s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/resource      123.647s

[tombuildsstuff]

hi @teowa

Thanks for this PR - I've taken a look through and left some comments inline, but if we can fix those up we should be able to take another look here.

Thanks!

[tombuildsstuff]

the two ID fields don't need to be nil-check'd here fwiw (and we can also move this struct initialization down)

Suggested change

	if model := resp.Model; model != nil {
	schema.Name = id.ResourceManagementPrivateLinkName
	schema.ResourceGroupName = id.ResourceGroupName
	schema := ResourceManagementPrivateLinkResourceSchema{
	Name: id.ResourceManagementPrivateLinkName,
	ResourceGroupName: id.ResourceGroupName,
	}
	if model := resp.Model; model != nil {

[teowa]

fixed.

[tombuildsstuff]

Given the nature of this field (the private endpoint connections) this information is likely not going to be useful on the Resource - but could make sense on a Data Source, what's the use-case for exposing this field?

[tombuildsstuff]

actually we're not setting this in the Read function at all, so can we remove this:

Suggested change

	"private_endpoint_connections": {
	Computed: true,
	Elem: &pluginsdk.Schema{
	Type: pluginsdk.TypeString,
	},
	Type: pluginsdk.TypeList,
	},

[teowa]

fixed.

[tombuildsstuff]

is this a resource generated via Pandora?

[teowa]

Yes, it is based on Pandora. I have modified the tools/importer to avoid some panic.

[tombuildsstuff]

the provider block should be in each test, not the template - can we update this

[teowa]

fixed.

[tombuildsstuff]

(as above) we likely don't want to expose this field:

Suggested change

* `private_endpoint_connections` - A list of private endpoint connections.

[teowa]

fixed.

[tombuildsstuff]

this should be within Resources (since it's tied to a Resource Group)

[teowa]

From architecture doc, it is currently only supported at Management Group level, so could we put under Management subcategory?
On the other hand, there is no Resources category:

terraform-provider-azurerm/internal/services/resource/registration.go

Lines 24 to 31 in b4bd986

	func (r Registration) WebsiteCategories() []string {
	return []string{
	"Base",
	"Management",
	"Template",
	}
	}

[tombuildsstuff]

can we expand on this

[teowa]

changed to:
Manages a Resource Management Private Link to restrict access for managing resources in the tenant.

[tombuildsstuff]

can we expand on this

[teowa]

changed to:
Manages a Resource Management Private Link to restrict access for managing resources in the tenant.

[stephybun]

@teowa something appears to be wrong with the import test:

------- Stdout: -------
=== RUN   TestAccResourceManagementPrivateLink_requiresImport
=== PAUSE TestAccResourceManagementPrivateLink_requiresImport
=== CONT  TestAccResourceManagementPrivateLink_requiresImport
    testcase.go:113: Step 2/2, expected an error with pattern, no match on: Error running pre-apply refresh: exit status 1
        Error: Duplicate provider configuration
          on terraform_plugin_test.tf line 22:
          22: provider "azurerm" {
        A default (non-aliased) provider configuration for "azurerm" was already
        given at terraform_plugin_test.tf:17,1-19. If multiple configurations are
        required, set the "alias" argument for alternative configurations.
    testing_new.go:79: Error retrieving state, there may be dangling resources: exit status 1

[stephybun]

Thanks @teowa LGTM 👍

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.