Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_container_app_environment - support dapr_application_insights_connection_string #23080

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

myc2h6o
Copy link
Contributor

@myc2h6o myc2h6o commented Aug 25, 2023

Close #20404
instrumentation key is being superseded by connection string, so adding support for connection string only:
https://learn.microsoft.com/azure/azure-monitor/app/sdk-connection-string?tabs=dotnet5#overview

@myc2h6o
Copy link
Contributor Author

myc2h6o commented Aug 25, 2023

Test result (TestAccContainerAppEnvironment_completeUpdate fails on main as well for same reason):
image

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff added this to the v3.72.0 milestone Aug 25, 2023
@tombuildsstuff tombuildsstuff merged commit 5ca4398 into hashicorp:main Aug 25, 2023
tombuildsstuff added a commit that referenced this pull request Aug 25, 2023
@myc2h6o myc2h6o deleted the app_dapr branch August 25, 2023 15:11
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update azurerm_container_app_environment resource to enable configuration of daprAIInstrumentationKey property
2 participants