Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_virtual_network_gateway: increase timeout for create #23003

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

wuxu92
Copy link
Contributor

@wuxu92 wuxu92 commented Aug 18, 2023

some acctest may failed occasionally with error we below, try to increase the timeout value.

=== CONT  TestAccVirtualNetworkGateway_requiresImport
    testcase.go:113: Step 1/2 error: Error running apply: exit status 1
        Error: waiting for completion of Virtual Network Gateway: (Name "acctestvng-230630050833542667" / Resource Group "acctestRG-230630050833542667"): 
Future#WaitForCompletion: context has been cancelled: StatusCode=200 -- Original Error: context deadline exceeded
=== CONT  TestAccVirtualNetworkGatewayConnection_natRuleIds
    testcase.go:113: Step 1/2 error: Error running apply: exit status 1
        Error: waiting for completion of Virtual Network Gateway: (Name "acctestvnetgw-230814084927775723" / Resource Group "acctestRG-230814084927775723"): Future#WaitForCompletion: context has been cancelled: StatusCode=200 -- Original Error: context deadline exceeded

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wuxu92, can you please update the docs as well?

@wuxu92
Copy link
Contributor Author

wuxu92 commented Aug 25, 2023

@stephybun document updated.

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @wuxu92

@tombuildsstuff tombuildsstuff dismissed stephybun’s stale review August 25, 2023 10:31

dismissing since changes have been pushed

@tombuildsstuff tombuildsstuff merged commit 7527697 into hashicorp:main Aug 25, 2023
tombuildsstuff added a commit that referenced this pull request Aug 25, 2023
@github-actions github-actions bot added this to the v3.72.0 milestone Aug 25, 2023
@wuxu92 wuxu92 deleted the acc/vnetgw_timeout branch August 25, 2023 11:00
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants