-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_linux/windows_virtual_machine_scale_set
- cancel rolling upgrades before deleting resource
#22991
azurerm_linux/windows_virtual_machine_scale_set
- cancel rolling upgrades before deleting resource
#22991
Conversation
…e from extensions resource
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @stephybun - One comment to address, otherwise LGTM 🐰
internal/services/compute/windows_virtual_machine_scale_set_resource_other_test.go
Outdated
Show resolved
Hide resolved
Co-authored-by: jackofallops <11830746+jackofallops@users.noreply.github.com>
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Supersedes #18973
This PR adds the functionality drafted in #18973 to the linux and windows VMSS.
I've intentionally omitted adding this to the extensions resource since it doesn't appear to be possible to configure rolling upgrades without specifying extensions in-line in the VMSS resource and setting extensions both in-line and with the extension resource causes diffs.
if there are issues with the deletion of extensions we can investigate and address this in a separate PR.