Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependencies: updating to v0.20230815.1165905 of github.com/hashicorp/go-azure-sdk #22981

Merged
merged 2 commits into from
Aug 16, 2023
Merged

dependencies: updating to v0.20230815.1165905 of github.com/hashicorp/go-azure-sdk #22981

merged 2 commits into from
Aug 16, 2023

Conversation

tombuildsstuff
Copy link
Contributor

This PR updates to v0.20230815.1165905 of github.com/hashicorp/go-azure-sdk - it also converts DevTestLabs over to using the new base layer from hashicorp/go-azure-sdk rather than Azure/go-autorest

Upstream PR: hashicorp/pandora#2864

@tombuildsstuff tombuildsstuff added this to the v3.70.0 milestone Aug 16, 2023
@tombuildsstuff tombuildsstuff requested a review from a team August 16, 2023 11:59
@tombuildsstuff
Copy link
Contributor Author

Tests look fine 👍

katbyte
katbyte approved these changes Aug 16, 2023
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🧪

@katbyte katbyte merged commit e936e80 into main Aug 16, 2023
@katbyte katbyte deleted the dependencies/go-azure-sdk branch August 16, 2023 14:53
katbyte added a commit that referenced this pull request Aug 16, 2023
@katbyte
Update CHANGELOG.md #22981
4e95133
@saveler saveler mentioned this pull request Sep 1, 2023
Open
1 task
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
dependencies service/devtestlabs size/XL
Projects
None yet
Milestone
v3.70.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tombuildsstuff @katbyte