Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: updating vpn_gateway to use hashicorp/go-azure-sdk #22906

Merged
merged 3 commits into from
Sep 5, 2023
Merged

refactor: updating vpn_gateway to use hashicorp/go-azure-sdk #22906

merged 3 commits into from
Sep 5, 2023

Conversation

tombuildsstuff
Copy link
Contributor

This PR updates the Data Source and Resource azurerm_vpn_gateway to use hashicorp/go-azure-sdk

@tombuildsstuff tombuildsstuff marked this pull request as ready for review August 10, 2023 14:29
@tombuildsstuff tombuildsstuff added this to the v3.70.0 milestone Aug 10, 2023
@tombuildsstuff tombuildsstuff requested a review from a team August 10, 2023 14:29
mbfrahry
mbfrahry approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we should fix up some of the potential crashes before merging

internal/services/network/vpn_gateway_resource.go Outdated Show resolved Hide resolved
internal/services/network/vpn_gateway_resource.go Outdated Show resolved Hide resolved
internal/services/network/vpn_gateway_resource.go Show resolved Hide resolved
internal/services/network/vpn_gateway_resource.go Show resolved Hide resolved
@tombuildsstuff tombuildsstuff modified the milestones: v3.70.0, v3.72.0 Aug 31, 2023
@stephybun
Copy link
Member

Applied review comments and tests look good.

@stephybun stephybun merged commit 4da169c into main Sep 5, 2023
@stephybun stephybun deleted the refactor/network-to-go-azure-sdk-3 branch September 5, 2023 08:48
stephybun added a commit that referenced this pull request Sep 7, 2023
@stephybun
Update for #23146 #23124 #23096 #22906 #23160 #23106 #22709
3abf2e4
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbfrahry mbfrahry mbfrahry approved these changes

Assignees
No one assigned
Labels
refactor service/network size/XL
Projects
None yet
Milestone
v3.72.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tombuildsstuff @stephybun @mbfrahry