Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_iothub_dps - fix casing of possible values for ip_filter_rule.target #22891

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

myc2h6o
Copy link
Contributor

@myc2h6o myc2h6o commented Aug 10, 2023

this resource started using new base layer hashicorp/pandora#2821 which normalizes the returned enum to the one specified in the swagger
Now the casing matches the swagger, however tests and documents are still with old values:

=== CONT  TestAccIotHubDPS_ipFilterRules
    testcase.go:113: Step 1/3 error: Check failed: Check 10/14 error: azurerm_iothub_dps.test: Attribute 'ip_filter_rule.0.target' expected "All", got "all"

updating them to the correct values

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @myc2h6o

@tombuildsstuff tombuildsstuff added this to the v3.70.0 milestone Aug 11, 2023
@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2023-08-11 at 08 12 04

@tombuildsstuff tombuildsstuff merged commit 14c68de into hashicorp:main Aug 11, 2023
@myc2h6o myc2h6o deleted the iotdps_test branch August 11, 2023 06:12
tombuildsstuff added a commit that referenced this pull request Aug 11, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants