Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

digitaltwins - updating to API Version 2023-01-31 / support for User Assigned Identities #22782

Merged
merged 5 commits into from
Aug 4, 2023
Merged

digitaltwins - updating to API Version 2023-01-31 / support for User Assigned Identities #22782

merged 5 commits into from
Aug 4, 2023

Conversation

tombuildsstuff
Copy link
Contributor

This PR updates digitaltwins to use API Version 2023-01-31 - and adds support for User Assigned Identities, which is available in this API version.

@tombuildsstuff tombuildsstuff added this to the v3.68.0 milestone Aug 2, 2023
@tombuildsstuff tombuildsstuff requested a review from a team August 2, 2023 06:53
manicminer
manicminer approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tombuildsstuff tombuildsstuff force-pushed the f/updating-digitaltwins branch from 092ff91 to b6b59d3 Compare August 2, 2023 14:25
tombuildsstuff added a commit to hashicorp/pandora that referenced this pull request Aug 2, 2023
@tombuildsstuff
tools/importer-rest-api-specs: adding a workaround for digitaltwins
e4ea691 
Unblocks hashicorp/terraform-provider-azurerm#22782
@tombuildsstuff tombuildsstuff mentioned this pull request Aug 2, 2023
Merged
@tombuildsstuff tombuildsstuff marked this pull request as draft August 2, 2023 15:20
@tombuildsstuff

This comment was marked as resolved.

Sign in to view
@tombuildsstuff tombuildsstuff added the upstream/pandora This issue/PR has a dependency on an issue in `github.com/hashicorp/pandora` label Aug 2, 2023
tombuildsstuff added a commit to hashicorp/pandora that referenced this pull request Aug 2, 2023
@tombuildsstuff
tools/importer-rest-api-specs: adding a workaround for digitaltwins
e2293a7 
Unblocks hashicorp/terraform-provider-azurerm#22782
@tombuildsstuff tombuildsstuff self-assigned this Aug 2, 2023
@tombuildsstuff

This comment was marked as resolved.

Sign in to view
@tombuildsstuff tombuildsstuff force-pushed the f/updating-digitaltwins branch from b6b59d3 to 40c3a67 Compare August 3, 2023 11:29
@tombuildsstuff tombuildsstuff modified the milestones: v3.68.0, v3.69.0 Aug 3, 2023
@tombuildsstuff tombuildsstuff removed the upstream/pandora This issue/PR has a dependency on an issue in `github.com/hashicorp/pandora` label Aug 3, 2023
@tombuildsstuff
Copy link
Contributor Author

Per this comment this is fine to ship with the workaround - removing Draft status.

@tombuildsstuff tombuildsstuff marked this pull request as ready for review August 4, 2023 07:02
@tombuildsstuff tombuildsstuff force-pushed the f/updating-digitaltwins branch from 1c805ca to ef1ebcd Compare August 4, 2023 09:57
@tombuildsstuff
Copy link
Contributor Author

Tests pass:

Screenshot 2023-08-04 at 12 38 45

@tombuildsstuff tombuildsstuff merged commit 83b1afc into main Aug 4, 2023
@tombuildsstuff tombuildsstuff deleted the f/updating-digitaltwins branch August 4, 2023 10:39
tombuildsstuff added a commit that referenced this pull request Aug 4, 2023
@tombuildsstuff
updating to include #22782
1ea562c
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@manicminer manicminer manicminer approved these changes

Assignees

@tombuildsstuff tombuildsstuff

Labels
dependencies documentation enhancement service/digital-twins size/XL
Projects
None yet
Milestone
v3.69.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tombuildsstuff @manicminer