Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependencies -automation: updating dscnodeconfiguration and sourcecontrol to use API Version 2022-08-08 #22781

Merged
merged 2 commits into from
Aug 2, 2023
Merged

dependencies -automation: updating dscnodeconfiguration and sourcecontrol to use API Version 2022-08-08 #22781

merged 2 commits into from
Aug 2, 2023

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff added this to the v3.68.0 milestone Aug 2, 2023
@tombuildsstuff
Copy link
Contributor Author

tombuildsstuff commented Aug 2, 2023 •
edited
Loading

Needs a go-azure-sdk update first, thought that'd already been done.. doing that now Turns out this is a separate issue during deletion

@tombuildsstuff tombuildsstuff self-assigned this Aug 2, 2023
@tombuildsstuff tombuildsstuff mentioned this pull request Aug 2, 2023
Merged
@tombuildsstuff tombuildsstuff reopened this Aug 2, 2023
@tombuildsstuff tombuildsstuff mentioned this pull request Aug 2, 2023
Merged
@tombuildsstuff tombuildsstuff marked this pull request as draft August 2, 2023 15:00
@tombuildsstuff tombuildsstuff force-pushed the f/updating/automation/dscnodeconfiguration-and-sourcecontrol-to-2022-08-08 branch from 0314c9f to c46775f Compare August 2, 2023 15:02
@tombuildsstuff tombuildsstuff force-pushed the f/updating/automation/dscnodeconfiguration-and-sourcecontrol-to-2022-08-08 branch from c46775f to 11b3f6a Compare August 2, 2023 15:26
@tombuildsstuff tombuildsstuff marked this pull request as ready for review August 2, 2023 15:28
@tombuildsstuff tombuildsstuff removed their assignment Aug 2, 2023
@tombuildsstuff tombuildsstuff requested a review from a team August 2, 2023 15:32
@tombuildsstuff
Copy link
Contributor Author

Tests pass:

Screenshot 2023-08-02 at 18 04 25

mbfrahry
mbfrahry approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry changed the title automation: updating dscnodeconfiguration and sourcecontrol to use API Version 2022-08-08 dependencies -automation: updating dscnodeconfiguration and sourcecontrol to use API Version 2022-08-08 Aug 2, 2023
@mbfrahry mbfrahry merged commit 2f24426 into main Aug 2, 2023
@mbfrahry mbfrahry deleted the f/updating/automation/dscnodeconfiguration-and-sourcecontrol-to-2022-08-08 branch August 2, 2023 16:58
mbfrahry added a commit that referenced this pull request Aug 2, 2023
@mbfrahry
Update CHANGELOG.md for #22781
7d03797
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbfrahry mbfrahry mbfrahry approved these changes

Assignees
No one assigned
Labels
dependencies enhancement service/automation size/XL
Projects
None yet
Milestone
v3.68.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tombuildsstuff @mbfrahry