azurerm_kubernetes_cluster - Update Azure CNI to Azure CNI Overlay enabled

[aristosvo]

Fixes #22704

Acctests

New test runs like a charm, other tests should not be affected as only the schema has a ForceNew=True removed.

[stephybun]

@aristosvo what happens if we try migrating in the other direction e.g. overlay -> azure?

[aristosvo]

I haven't tried yet, the docs seem unclear. I'll give it a try!

[katbyte]

Looks like we have some test failures:

Error: creating Kubernetes Cluster (Subscription: "*******"
        Resource Group Name: "acctestRG-230802013926273291"
        Kubernetes Cluster Name: "acctestaks230802013926273291"): managedclusters.ManagedClustersClient#CreateOrUpdate: Failure sending request: StatusCode=0 -- Original Error: Code="AgentPoolK8sVersionNotSupported" Message="Version 1.25.5 is not supported in this region. Please use [az aks get-versions] command to get the supported version list in this region. For more information, please check https://aka.ms/supported-version-list"
        
          with azurerm_kubernetes_cluster.test,
          on terraform_plugin_test.tf line 76, in resource "azurerm_kubernetes_cluster" "test":
          76: resource "azurerm_kubernetes_cluster" "test" {

[aristosvo]

@katbyte I think these are unrelated, at least as far as I can interpret them

@stephybun I made it a one-way migration for now, as I think it should be. Test is broken because of the public_network_access_enabled change, but other than that it should be fine!

[stephybun]

Thanks @aristosvo. Hope you don't mind I rebased your branch to pull in the test fix for public_network_access_enabled.

I have one suggestion to simplify the ForceNew condition but otherwise this looks like it's ready.

[stephybun]

Thanks @aristosvo LGTM 👍

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.