network - refactoring the usages of hashicorp/go-azure-sdk to use a Meta Client
#22676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
waiting-response
dependencies
service/databricks
service/signalr
service/network
size/XL
and removed
waiting-response
labels
mbfrahry
approved these changes
Jul 26, 2023
… the meta client
…ct Subnet ID We shouldn't be using `d.Get` within the Delete function, since this isn't guaranteed to return a value - since these are returned from the API we can look these up instead.
tombuildsstuff
force-pushed
the
refactor/network-gets-a-meta-client
branch
from
374273d to
562ea76
Compare
tombuildsstuff
added a commit
that referenced
this pull request
Jul 28, 2023
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
networkclients which make use ofhashicorp/go-azure-sdkto make use of a Meta Client, rather than importing these individually.Since we import basically the entirety of the
networkpackage, using a Meta Client will make life easier here since we can update all of the Clients to use the same API version at once - rather than importing different versions of the SDK / having conflicts across PR's.