Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_netapp_volume_group_sap_hana - update the validation of security_style #22615

Merged
merged 10 commits into from
Jul 28, 2023

Conversation

neil-yechenwei
Copy link
Contributor

@neil-yechenwei neil-yechenwei commented Jul 20, 2023

fixes #22582

image

Note: Currently all related test cases are failed in Teamcity Daily Run due to quota issue. I found seems this resource is only available in eastus so that I updated the test location. However, its' pair region westus is still unavailable so that TestAccNetAppVolumeGroupSapHana_crossRegionReplication is still failed. But this failed test case is not related with this PR.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…style

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@neil-yechenwei neil-yechenwei changed the title azurerm_netapp_volume_group_sap_hana - add diffsuppress for security_style azurerm_netapp_volume_group_sap_hana - update the validation of security_style Jul 20, 2023
@github-actions github-actions bot added size/M and removed size/XS labels Jul 20, 2023
@@ -67,8 +67,8 @@ func PossibleValuesForProtocolTypeVolumeGroupSapHana() []string {
type SecurityStyle string

const (
SecurityStyleUnix SecurityStyle = "Unix"
SecurityStyleNtfs SecurityStyle = "Ntfs"
SecurityStyleUnix SecurityStyle = "unix"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we remove these and use the enum mentioned above instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to use enum values in go azure sdk.

@neil-yechenwei
Copy link
Contributor Author

@catriona-m , thanks for the comment. I updated PR. Please take another look. Thanks.

Comment on lines 167 to 168
// Diverging from the SDK volumegroups.SecurityStyle since it is defined as lower case
// but the backend changes it to Pascal case on GET. Please refer to https://github.com/Azure/azure-sdk-for-go/issues/14684
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems this comment may no longer be relevant given that this resource is using the hashicorp/go-azure-sdk

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

@github-actions github-actions bot added size/M and removed size/L labels Jul 26, 2023
@neil-yechenwei
Copy link
Contributor Author

neil-yechenwei commented Jul 26, 2023

@catriona-m , thanks for the comment. I updated PR. Please take another look. Thanks.

Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neil-yechenwei LGTM!

@catriona-m catriona-m merged commit 9f0bcc3 into hashicorp:main Jul 28, 2023
@github-actions github-actions bot added this to the v3.68.0 milestone Jul 28, 2023
catriona-m added a commit that referenced this pull request Jul 28, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azurerm_netapp_volume_group_sap_hana volume security style "unix" forces replacement
2 participants