-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_netapp_volume_group_sap_hana
- update the validation of security_style
#22615
azurerm_netapp_volume_group_sap_hana
- update the validation of security_style
#22615
Conversation
azurerm_netapp_volume_group_sap_hana
- add diffsuppress
for security_style
azurerm_netapp_volume_group_sap_hana
- update the validation of security_style
@@ -67,8 +67,8 @@ func PossibleValuesForProtocolTypeVolumeGroupSapHana() []string { | |||
type SecurityStyle string | |||
|
|||
const ( | |||
SecurityStyleUnix SecurityStyle = "Unix" | |||
SecurityStyleNtfs SecurityStyle = "Ntfs" | |||
SecurityStyleUnix SecurityStyle = "unix" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we remove these and use the enum mentioned above instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to use enum values in go azure sdk.
@catriona-m , thanks for the comment. I updated PR. Please take another look. Thanks. |
// Diverging from the SDK volumegroups.SecurityStyle since it is defined as lower case | ||
// but the backend changes it to Pascal case on GET. Please refer to https://github.com/Azure/azure-sdk-for-go/issues/14684 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems this comment may no longer be relevant given that this resource is using the hashicorp/go-azure-sdk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed.
@catriona-m , thanks for the comment. I updated PR. Please take another look. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @neil-yechenwei LGTM!
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
fixes #22582
Note: Currently all related test cases are failed in Teamcity Daily Run due to quota issue. I found seems this resource is only available in eastus so that I updated the test location. However, its' pair region westus is still unavailable so that TestAccNetAppVolumeGroupSapHana_crossRegionReplication is still failed. But this failed test case is not related with this PR.