Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_spring_cloud_service - support for the marketplace property #22553

Conversation

ms-henglu
Copy link
Contributor

@ms-henglu ms-henglu commented Jul 17, 2023

Hi reviewers,

I understand it's not recommended to use Optional+Computed, but the service will add a default value for the existing services, without Computed, it would be a breaking change to the existing users.

=== RUN   TestAccSpringCloudService_basic
=== PAUSE TestAccSpringCloudService_basic
=== CONT  TestAccSpringCloudService_basic
--- PASS: TestAccSpringCloudService_basic (415.59s)
=== RUN   TestAccSpringCloudService_update
=== PAUSE TestAccSpringCloudService_update
=== CONT  TestAccSpringCloudService_update
--- PASS: TestAccSpringCloudService_update (1001.05s)
=== RUN   TestAccSpringCloudService_complete
=== PAUSE TestAccSpringCloudService_complete
=== CONT  TestAccSpringCloudService_complete
--- PASS: TestAccSpringCloudService_complete (553.41s)
=== RUN   TestAccSpringCloudService_virtualNetwork
=== PAUSE TestAccSpringCloudService_virtualNetwork
=== CONT  TestAccSpringCloudService_virtualNetwork
=== CONT  TestAccSpringCloudService_virtualNetwork
--- PASS: TestAccSpringCloudService_virtualNetwork (413.76s)
=== RUN   TestAccSpringCloudService_requiresImport
=== PAUSE TestAccSpringCloudService_requiresImport
=== CONT  TestAccSpringCloudService_requiresImport
--- PASS: TestAccSpringCloudService_requiresImport (334.43s)
=== RUN   TestAccSpringCloudService_serviceRegistry
=== PAUSE TestAccSpringCloudService_serviceRegistry
=== CONT  TestAccSpringCloudService_serviceRegistry
--- PASS: TestAccSpringCloudService_serviceRegistry (650.43s)
=== RUN   TestAccSpringCloudService_buildAgentPool
=== PAUSE TestAccSpringCloudService_buildAgentPool
=== CONT  TestAccSpringCloudService_buildAgentPool
--- PASS: TestAccSpringCloudService_buildAgentPool (596.56s)
=== RUN   TestAccSpringCloudService_zoneRedundant
=== PAUSE TestAccSpringCloudService_zoneRedundant
=== CONT  TestAccSpringCloudService_zoneRedundant
--- PASS: TestAccSpringCloudService_zoneRedundant (413.91s)
=== RUN   TestAccSpringCloudService_containerRegistry
=== PAUSE TestAccSpringCloudService_containerRegistry
=== CONT  TestAccSpringCloudService_containerRegistry
--- PASS: TestAccSpringCloudService_containerRegistry (585.85s)
=== RUN   TestAccSpringCloudService_marketplace
=== PAUSE TestAccSpringCloudService_marketplace
=== CONT  TestAccSpringCloudService_marketplace
--- PASS: TestAccSpringCloudService_marketplace (451.26s)

Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ms-henglu, pending tests this LGTM with some adjustments to the docs wording

website/docs/r/spring_cloud_service.html.markdown Outdated Show resolved Hide resolved
website/docs/r/spring_cloud_service.html.markdown Outdated Show resolved Hide resolved
website/docs/r/spring_cloud_service.html.markdown Outdated Show resolved Hide resolved
@ms-henglu
Copy link
Contributor Author

Hi @manicminer ,

Thanks for the code review, the tests are passing now, would you please merge it, thanks!
image

@manicminer manicminer added this to the v3.66.0 milestone Jul 20, 2023
@manicminer manicminer merged commit 3eab7d3 into hashicorp:main Jul 20, 2023
manicminer added a commit that referenced this pull request Jul 20, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants