Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_cosmosdb_account - Mark cors_rule.max_age_in_seconds as Optional and update the validation #22552

Merged
merged 2 commits into from
Jul 25, 2023
Merged

azurerm_cosmosdb_account - Mark cors_rule.max_age_in_seconds as Optional and update the validation #22552

merged 2 commits into from
Jul 25, 2023

Conversation

neil-yechenwei
Copy link
Contributor

@neil-yechenwei neil-yechenwei commented Jul 17, 2023 •
edited
Loading

fixes #22509

image

katbyte
katbyte approved these changes Jul 21, 2023
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once conflicts are resolved 🌳

@neil-yechenwei
Copy link
Contributor Author

neil-yechenwei commented Jul 21, 2023 •
edited
Loading

@katbyte , I've resolved the conflicts. Please take another look. Thanks.

image

@neil-yechenwei neil-yechenwei requested a review from katbyte July 21, 2023 06:11
catriona-m
catriona-m approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neil-yechenwei LGTM!

@catriona-m catriona-m merged commit b755796 into hashicorp:main Jul 25, 2023
@github-actions github-actions bot added this to the v3.67.0 milestone Jul 25, 2023
catriona-m added a commit that referenced this pull request Jul 25, 2023
@catriona-m
Update CHANGELOG.md for #22552
38c4073
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@catriona-m catriona-m catriona-m approved these changes

@katbyte katbyte Awaiting requested review from katbyte

Assignees
No one assigned
Labels
documentation service/cosmosdb size/M
Projects
None yet
Milestone
v3.67.0
Development

Successfully merging this pull request may close these issues.

azurerm_cosmosdb_account => cors_rule => max_age_in_seconds
3 participants
@neil-yechenwei @katbyte @catriona-m