Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Data Source: azurerm_key_vault_key #2231

Merged
merged 2 commits into from
Nov 5, 2018

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Nov 4, 2018

Probably dependent on #2229

Tests pass:

$ acctests azurerm TestAccDataSourceAzureRMKeyVaultKey_complete
=== RUN   TestAccDataSourceAzureRMKeyVaultKey_complete
--- PASS: TestAccDataSourceAzureRMKeyVaultKey_complete (274.38s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	275.408s

Fixes #1455

@tombuildsstuff tombuildsstuff added this to the 1.19.0 milestone Nov 4, 2018
@ghost ghost added the size/XL label Nov 4, 2018
```
$ acctests azurerm TestAccDataSourceAzureRMKeyVaultKey_complete
=== RUN   TestAccDataSourceAzureRMKeyVaultKey_complete
--- PASS: TestAccDataSourceAzureRMKeyVaultKey_complete (274.38s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	275.408s
```
@tombuildsstuff tombuildsstuff force-pushed the f/data-source-key-vault-key branch from 90797a3 to df62585 Compare November 4, 2018 23:33
@ghost ghost added size/L and removed size/XL labels Nov 4, 2018
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

azurerm/data_source_key_vault_key.go Show resolved Hide resolved
Copy link
Contributor

@metacpp metacpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Tests pass:

```
$ acctests azurerm TestAccDataSourceAzureRMKeyVaultKey_complete
=== RUN   TestAccDataSourceAzureRMKeyVaultKey_complete
--- PASS: TestAccDataSourceAzureRMKeyVaultKey_complete (210.76s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	212.678s
```
@tombuildsstuff tombuildsstuff merged commit a9956cf into master Nov 5, 2018
@tombuildsstuff tombuildsstuff deleted the f/data-source-key-vault-key branch November 5, 2018 10:33
tombuildsstuff added a commit that referenced this pull request Nov 5, 2018
tombuildsstuff added a commit that referenced this pull request Nov 5, 2018
@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants