Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_site_recovery_replicated_vm: fix a bug of setting network_interface.failover_test_subnet_name , network_interface.failover_test_public_ip_address_id and network_interface.failover_test_static_ip #22217

Merged
merged 2 commits into from
Jun 26, 2023

Conversation

ziyeqf
Copy link
Contributor

@ziyeqf ziyeqf commented Jun 20, 2023

fix #22193

these failed ones are also failing on main branch which I assume does not block this PR.
Screenshot 2023-06-21 at 14 40 15

Signed-off-by: ziyeqf <[email protected]>
@ziyeqf ziyeqf changed the title azurerm_site_recovery_replicated_vm: fix a bug of network_interface.failover_test_subnet_name , network_interface.failover_test_public_ip_address_id and network_interface.failover_test_static_ip azurerm_site_recovery_replicated_vm: fix a bug of setting network_interface.failover_test_subnet_name , network_interface.failover_test_public_ip_address_id and network_interface.failover_test_static_ip Jun 20, 2023
@ziyeqf ziyeqf force-pushed the tengzh/issue/replicated_vm_tfo branch from e869d1a to fc5ea04 Compare June 20, 2023 07:41
@github-actions github-actions bot added size/S and removed size/XS labels Jun 21, 2023
Signed-off-by: ziyeqf <[email protected]>
@ziyeqf ziyeqf force-pushed the tengzh/issue/replicated_vm_tfo branch from 3922d97 to 8f254ff Compare June 21, 2023 02:22
@ziyeqf ziyeqf marked this pull request as ready for review June 21, 2023 06:41
@stephybun stephybun added the bug label Jun 26, 2023
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ziyeqf LGTM 🍈

@stephybun stephybun merged commit cce96f2 into hashicorp:main Jun 26, 2023
@github-actions github-actions bot added this to the v3.63.0 milestone Jun 26, 2023
stephybun added a commit that referenced this pull request Jun 26, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_site_recovery_replicated_vm failover_test network configuration failed
2 participants