Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for permanently-delete in azurerm_machine_learning_workspace #22171

Closed
1 task done
domirohner opened this issue Jun 14, 2023 · 12 comments
Closed
1 task done

Support for permanently-delete in azurerm_machine_learning_workspace #22171

domirohner opened this issue Jun 14, 2023 · 12 comments

Comments

@domirohner
Copy link

domirohner commented Jun 14, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Azure recently added a new feature soft-deletion for Azure Machine Learning Workspaces (https://learn.microsoft.com/en-us/azure/machine-learning/concept-soft-delete?view=azureml-api-2).
With this feature you need to hard-delete the ML workspace before you can re-create the workspace with the same name again (e.g. in pipelines).

It would be really helpful if you could also integrate the permanantly-delete option (https://learn.microsoft.com/en-us/cli/azure/ml/workspace?view=azure-cli-latest#az-ml-workspace-delete) in Terraform.

New or Affected Resource(s)/Data Source(s)

azurerm_machine_learning_workspace

Potential Terraform Configuration

Maybe it can be solved with a similar feature as with the KeyVault (https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/key_vault):

provider "azurerm" {
  features {
    azurerm_machine_learning_workspace {
      purge_soft_delete_on_destroy = false
    }
  }
}
@meierale
Copy link

I was just about to open this issue as well. As we have automated jobs that create and destroy our machine learning development & test infrastructure on a daily basis, our setup is currently broken until such a feature is implemented.

@youlitai003
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Azure recently added a new feature soft-deletion for Azure Machine Learning Workspaces (https://learn.microsoft.com/en-us/azure/machine-learning/concept-soft-delete?view=azureml-api-2). With this feature you need to hard-delete the ML workspace before you can re-create the workspace with the same name again (e.g. in pipelines).

It would be really helpful if you could also integrate the permanantly-delete option (https://learn.microsoft.com/en-us/cli/azure/ml/workspace?view=azure-cli-latest#az-ml-workspace-delete) in Terraform.

New or Affected Resource(s)/Data Source(s)

azurerm_machine_learning_workspace

Potential Terraform Configuration

Maybe it can be solved with a similar feature as with the KeyVault (https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/key_vault):

provider "azurerm" {
  features {
    azurerm_machine_learning_workspace {
      purge_soft_delete_on_destroy = false
    }
  }
}

My automation is currently broken now and either "azurerm_machine_learning_workspace" or "machine_learning_workspace" are not supported in features block.

@sharccc
Copy link

sharccc commented Jul 10, 2023

HashiCorp internal reference IPL-4256 (Terraform Support)

@sturlabragason-devoteam
Copy link

sturlabragason-devoteam commented Aug 8, 2023

Until it's supported I ended up just using:

echo "Deleting ml workspace outside of terraform : https://github.com/hashicorp/terraform-provider-azurerm/issues/22171"
az login --service-principal -u $ARM_CLIENT_ID -p $ARM_CLIENT_SECRET --tenant $ARM_TENANT_ID -o none
az extension add --name ml
az ml workspace delete --name workspacename --resource-group rgname -resources --yes --permanently-delete

echo "Initializing Terraform..."
terraform -chdir=terraform init 

echo "Destroying Terraform configuration..."
terraform -chdir=terraform destroy -auto-approve

@meierale
Copy link

@sharccc can you give an update please? Is that support coming any time soon?

@domirohner

This comment was marked as duplicate.

@naveensy

This comment was marked as duplicate.

@MarkDNL

This comment was marked as duplicate.

@emad0082
Copy link

Any info on this, we are currently also seeing a demand for full deletion of the azure machine learning workspace.

@sharccc
Copy link

sharccc commented Apr 17, 2024

potentially fixed via #25624
(merged 4 commits into [main] 5 hours ago)

@stephybun
Copy link
Member

Closed by #25624

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

10 participants