Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_resource_deployment_script_* - fix issue where identity wasn't specified but was being sent as TypeNone to the api #22165

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

ms-zhenhua
Copy link
Contributor

@ms-zhenhua ms-zhenhua commented Jun 14, 2023

image

--- PASS: TestAccResourceDeploymentScriptAzurePowerShell_scriptUri (232.92s)
--- PASS: TestAccResourceDeploymentScriptAzureCLI_requiresImport (258.26s)
--- PASS: TestAccResourceDeploymentScriptAzurePowerShell_requiresImport (259.80s)
--- PASS: TestAccResourceDeploymentScriptAzureCLI_complete (261.86s)
--- PASS: TestAccResourceDeploymentScriptAzureCLI_basic (298.89s)
--- PASS: TestAccResourceDeploymentScriptAzurePowerShell_basic (303.84s)
--- PASS: TestAccResourceDeploymentScriptAzurePowerShell_complete (318.41s)
--- PASS: TestAccResourceDeploymentScriptAzurePowerShell_update (325.89s)
--- PASS: TestAccResourceDeploymentScriptAzureCLI_update (378.07s)
PASS
ok github.com/hashicorp/terraform-provider-azurerm/internal/services/resource 383.068s

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry changed the title Resources - Fix failed tests azurerm_resource_deployment_script_* - fix issue where identity wasn't specified but was being sent as TypeNone to the api Jun 15, 2023
@mbfrahry mbfrahry added this to the v3.62.0 milestone Jun 15, 2023
@mbfrahry mbfrahry merged commit ca63a09 into hashicorp:main Jun 15, 2023
mbfrahry added a commit that referenced this pull request Jun 15, 2023
ziyeqf pushed a commit to ziyeqf/terraform-provider-azurerm that referenced this pull request Jun 26, 2023
…asn't specified but was being sent as `TypeNone` to the api (hashicorp#22165)
ziyeqf pushed a commit to ziyeqf/terraform-provider-azurerm that referenced this pull request Jun 26, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants