Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_application_insights_workbook - fix update display_name without tags #22148

Conversation

teowa
Copy link
Contributor

@teowa teowa commented Jun 13, 2023

TF_ACC=1 go test -v ./internal/services/applicationinsights -parallel 50 -test.run=TestAccApplicationInsightsWorkbook_ -timeout 1440m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccApplicationInsightsWorkbook_basic
=== PAUSE TestAccApplicationInsightsWorkbook_basic
=== RUN   TestAccApplicationInsightsWorkbook_requiresImport
=== PAUSE TestAccApplicationInsightsWorkbook_requiresImport
=== RUN   TestAccApplicationInsightsWorkbook_complete
=== PAUSE TestAccApplicationInsightsWorkbook_complete
=== RUN   TestAccApplicationInsightsWorkbook_updateDisplanName
=== PAUSE TestAccApplicationInsightsWorkbook_updateDisplanName
=== RUN   TestAccApplicationInsightsWorkbook_update
=== PAUSE TestAccApplicationInsightsWorkbook_update
=== RUN   TestAccApplicationInsightsWorkbook_hiddenTitleInTags
=== PAUSE TestAccApplicationInsightsWorkbook_hiddenTitleInTags
=== CONT  TestAccApplicationInsightsWorkbook_basic
=== CONT  TestAccApplicationInsightsWorkbook_updateDisplanName
=== CONT  TestAccApplicationInsightsWorkbook_complete
=== CONT  TestAccApplicationInsightsWorkbook_hiddenTitleInTags
=== CONT  TestAccApplicationInsightsWorkbook_update
=== CONT  TestAccApplicationInsightsWorkbook_requiresImport
--- PASS: TestAccApplicationInsightsWorkbook_hiddenTitleInTags (6.70s)
--- PASS: TestAccApplicationInsightsWorkbook_basic (133.02s)
--- PASS: TestAccApplicationInsightsWorkbook_requiresImport (137.27s)
--- PASS: TestAccApplicationInsightsWorkbook_complete (156.84s)
--- PASS: TestAccApplicationInsightsWorkbook_updateDisplanName (160.42s)
--- PASS: TestAccApplicationInsightsWorkbook_update (273.28s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/applicationinsights   276.837s

Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @teowa - I have left a couple of minor comments inline here but can take another look once those get fixed up. Thanks!

Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those changes @teowa - LGTM!

@catriona-m catriona-m merged commit ed8e6f9 into hashicorp:main Jun 14, 2023
@github-actions github-actions bot added this to the v3.62.0 milestone Jun 14, 2023
catriona-m added a commit that referenced this pull request Jun 14, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_application_insights_workbook, cannot change workbook display_name
2 participants