Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_network_manager* - switch to use go-azure-sdk #22119

Merged
merged 4 commits into from
Jun 16, 2023

Conversation

teowa
Copy link
Contributor

@teowa teowa commented Jun 12, 2023

No description provided.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we need to do a state migration for the manage group id?

-/+ resource "azurerm_network_manager_management_group_connection" "test" {
              ~ connection_state    = "Pending" -> (known after apply)
              ~ id                  = "/providers/Microsoft.Management/managementGroups/43c2ab5a-8142-4573-ab5c-f05d32e100fb/providers/Microsoft.Network/networkManagerConnections/acctest-nmmgc-230612170319468265" -> (known after apply)
              ~ management_group_id = "43c2ab5a-8142-4573-ab5c-f05d32e100fb" -> "/providers/Microsoft.Management/managementGroups/43c2ab5a-8142-4573-ab5c-f05d32e100fb" # forces replacement
                name                = "acctest-nmmgc-230612170319468265"
                # (1 unchanged attribute hidden)
            }

@teowa
Copy link
Contributor Author

teowa commented Jun 14, 2023

image

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ☔

@katbyte katbyte merged commit 3ff7fe7 into hashicorp:main Jun 16, 2023
@github-actions github-actions bot added this to the v3.62.0 milestone Jun 16, 2023
katbyte added a commit that referenced this pull request Jun 16, 2023
ziyeqf pushed a commit to ziyeqf/terraform-provider-azurerm that referenced this pull request Jun 26, 2023
ziyeqf pushed a commit to ziyeqf/terraform-provider-azurerm that referenced this pull request Jun 26, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants