-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_express_route_port_authorization
: add a lock when create/update/delete authorization of express route port
#21959
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also lock azurerm_express_route_port
during Create/Update/Delete?
@mbfrahry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, but we could get into a scenario where we run into issues because we didn't lock the parent resource. It's rare to cause issues but whenever we lock a parent resource in a child resource, we should also lock the parent resource.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for adding that lock @wuxu92 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
The API permits only one create/update/delete operation on the same express route port resource. Or the API will reponse error as below. this was found in the failure of AccTest TestAccExpressRoutePortAuthorization_multiple
AccTest Result: