Allow user assigned and system managed identities on the same resource #2188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombuildsstuff
added
enhancement
service/virtual-machine
service/vmss
|
Ignoring a couple of temporary test failures the VMSS tests look good:
|
|
ignoring a known test failure - the VM tests pass:
|
tombuildsstuff
force-pushed
the
f-multiple-identity
branch
from
62600e3 to
7c6eb8c
Compare
|
@rrudduck I hope you don't mind I've rebased this / pushed a commit to update this to match the recent linting changes 👍 |
tombuildsstuff
approved these changes
Nov 6, 2018
tombuildsstuff
added a commit
that referenced
this pull request
Nov 6, 2018
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Virtual Machines and Virtual Machine Scale Sets it is possible to have both a system assigned identity along with multiple user assigned identities. This PR address this by allowing both to specified when the "SystemAssigned, UserAssigned" identity type is specified.