Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SQL MI managed instance missing attributes in azurerm 3.56.0 (zone_redundant and storage_account_type=GZRS) #21844

Open
1 task done
LaurentLesle opened this issue May 19, 2023 · 4 comments
Labels
enhancement service/mssql Microsoft SQL Server

Comments

@LaurentLesle
Copy link
Contributor

LaurentLesle commented May 19, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Add support for:

  • zone_redundant - Whether or not the multi-az is enabled. (bool)
  • storage_account_type - Add support for GZRS (The storage account type to be used to store backups for this instance. The options are Local (LocallyRedundantStorage), Zone (ZoneRedundantStorage), Geo (GeoRedundantStorage) and GeoZone(GeoZoneRedundantStorage))

Description

Add support for zone_redundant support. Current deployment of SQL MI servers are deployed with zoneRedundant set to false

image

New or Affected Resource(s)/Data Source(s)

azurerm_mssql_managed_instance

Potential Terraform Configuration

optional attribute. false by default


zone_redundant = true

References

https://learn.microsoft.com/en-us/azure/templates/microsoft.sql/managedinstances?pivots=deployment-language-terraform
(version - 2021-11-01)

@LaurentLesle LaurentLesle changed the title Add SQL MI managed instance missing attributes in azurerm 3.56.0 Add SQL MI managed instance missing attributes in azurerm 3.56.0 (zoneRedundant and storage_account_type=GZRS) May 19, 2023
@LaurentLesle LaurentLesle changed the title Add SQL MI managed instance missing attributes in azurerm 3.56.0 (zoneRedundant and storage_account_type=GZRS) Add SQL MI managed instance missing attributes in azurerm 3.56.0 (zone_redundant and storage_account_type=GZRS) May 19, 2023
@mybayern1974 mybayern1974 added enhancement service/mssql Microsoft SQL Server labels May 19, 2023
@dtherkil
Copy link

Zone redundancy is now GA for Business Critical Managed Instances so hoping for both these enchancements be implemented soon. GRZS has been for GA for a while.

@fgarcia-cnb
Copy link

its been a year since this issue was opened. how has it not been resolved yet? pretty simple fix

@Azkel
Copy link

Azkel commented Jun 28, 2024

I see that both of those functionalities has been added:

@fgarcia-cnb
Copy link

fgarcia-cnb commented Jul 8, 2024

I changed the replication type to GZRS on an existing sql mi through the portal. unfortunately, according to this article it can take up to 24 hours for the change to take effect, so immediate terraform runs will still see pending changes.

that said, after 24 hours, i see my storage account now has GZRS configured, but terraform runs are still seeing GRS:

current resource JSON:

"currentBackupStorageRedundancy": "GeoZone",
"requestedBackupStorageRedundancy": "GeoZone",

but terraform sees:

image

somehow its not detecting GZRS. also, going from GRS->GZRS should not force a rebuild. it can be done in place

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement service/mssql Microsoft SQL Server
Projects
None yet
Development

No branches or pull requests

5 participants