AKS' temporary_name_for_rotation should also work for os_disk_type and zones

[mkemmerz]

Is there an existing issue for this?

• I have searched the existing issues

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The feature itself is working great if you change the VM Sku. Sadly it wants to recreate the AKS resource on changes of os_disk_type:

This is the same for zones. The AKS resource will be destroyed and created again if the availablity zones are changed.

In the past we have migrated such nodepools the same way the provider is doing it now with the temporary nodepool. Therefore I see no reason to not support those cases as well.

Expected behavior:
On changing the os_disk_type or zones the same behavior is applied as it is with changing the VM size.

New or Affected Resource(s)/Data Source(s)

azurerm_kubernetes_cluster

Probablyt his if:

terraform-provider-azurerm/internal/services/containers/kubernetes_cluster_resource.go

Line 2066 in fbf5346

if d.HasChange("default_node_pool.0.vm_size") || d.HasChange("default_node_pool.0.name") {

Potential Terraform Configuration

-

References

[mkemmerz]

Closing this issue as I have just found: #21719

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.