internal/clients: updating the IsAzureStack check to use go-azure-sdk
#21697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombuildsstuff
force-pushed
the
refactor/stack-check-to-go-azure-sdk
branch
from
1f9e0d0 to
1dbe1d9
Compare
tombuildsstuff
force-pushed
the
refactor/stack-check-to-go-azure-sdk
branch
from
1dbe1d9 to
47a900f
Compare
…sdk` I looked into removing the rest of the `authentication` package but it's needed until Giovanni's switched over to using `hashicorp/go-azure-sdk`
tombuildsstuff
force-pushed
the
refactor/stack-check-to-go-azure-sdk
branch
from
47a900f to
b069467
Compare
stephybun
approved these changes
May 8, 2023
tombuildsstuff
added a commit
that referenced
this pull request
May 8, 2023
ziyeqf
pushed a commit
to ziyeqf/terraform-provider-azurerm
that referenced
this pull request
May 8, 2023
ziyeqf
pushed a commit
to ziyeqf/terraform-provider-azurerm
that referenced
this pull request
May 8, 2023
|
This functionality has been released in v3.56.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looked into removing the rest of the
authenticationpackage but it's needed until Giovanni's switched over to usinghashicorp/go-azure-sdk