azurerm_active_directory_domain_service - domain_name now supports a length of 30
#21555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
mbfrahry
changed the title
azurerm_active_directory_domain_service - domain_name now supports a length of 30
mbfrahry
added a commit
that referenced
this pull request
Apr 27, 2023
xiaxyi
pushed a commit
to xiaxyi/terraform-provider-azurerm
that referenced
this pull request
Apr 28, 2023
…s a length of `30` (hashicorp#21555)
xiaxyi
pushed a commit
to xiaxyi/terraform-provider-azurerm
that referenced
this pull request
Apr 28, 2023
|
This functionality has been released in v3.54.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I actually originally contributed the domain_name validation, including lenght, but it turns out even though the Microsoft documentation describes a max length of 15 characters in the first element of the domain, it works just fine with longer, and I have found environments now unable to upgrade as they have 20-something characters.
Updated the validation and the tests of the validation.