Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_recovery_services_protected_vm: fix docs and mark backup_policy_id as required #2154

Merged
merged 1 commit into from
Oct 30, 2018
Merged

azurerm_recovery_services_protected_vm: fix docs and mark backup_policy_id as required #2154

merged 1 commit into from
Oct 30, 2018

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Oct 24, 2018 •
edited
Loading

fixes #2143

@katbyte katbyte added this to the 1.18.0 milestone Oct 24, 2018
@katbyte katbyte requested a review from a team October 24, 2018 23:02
@ghost ghost added the size/XS label Oct 24, 2018
@katbyte katbyte force-pushed the b/recovery_services-req branch from bae31e9 to 8add570 Compare October 24, 2018 23:03
mbfrahry
mbfrahry approved these changes Oct 24, 2018
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when tests finish

@katbyte katbyte requested a review from WodansSon October 25, 2018 14:59
metacpp
metacpp approved these changes Oct 29, 2018
View reviewed changes
Copy link
Contributor

@metacpp metacpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

tombuildsstuff
tombuildsstuff approved these changes Oct 30, 2018
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff
Copy link
Contributor

Tests pass:

screenshot 2018-10-30 at 10 04 58

@tombuildsstuff tombuildsstuff merged commit 9bd6db9 into master Oct 30, 2018
@tombuildsstuff tombuildsstuff deleted the b/recovery_services-req branch October 30, 2018 10:05
tombuildsstuff added a commit that referenced this pull request Oct 30, 2018
@tombuildsstuff
Updating to include #2154
28d5670
This was referenced Nov 2, 2018
Closed
Closed
@katbyte katbyte mentioned this pull request Nov 9, 2018
Closed
@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbfrahry mbfrahry mbfrahry approved these changes

@metacpp metacpp metacpp approved these changes

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

@WodansSon WodansSon Awaiting requested review from WodansSon

Assignees

@WodansSon WodansSon

Labels
bug documentation service/recovery-services size/XS
Projects
None yet
Milestone
v1.18.0
Development

Successfully merging this pull request may close these issues.

Error applying azurerm_recovery_services_protected_vm to virtual machine
5 participants
@katbyte @tombuildsstuff @metacpp @mbfrahry @WodansSon