Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_firewall_policy_rule_collection_group validation bug with ip ranges in "source_addresses" #21534

Closed
1 task done
joakimlemb opened this issue Apr 25, 2023 · 2 comments · Fixed by #21542
Closed
1 task done

Comments

@joakimlemb
Copy link

joakimlemb commented Apr 25, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

1.4.2

AzureRM Provider Version

3.52.0

Affected Resource(s)/Data Source(s)

azurerm_firewall_policy_rule_collection_group

Terraform Configuration Files

resource "azurerm_firewall_policy_rule_collection_group" "example" {
  name               = "example-fwpolicy-rcg"
  firewall_policy_id = azurerm_firewall_policy.example.id
  priority           = 500

  network_rule_collection {
    name     = "network_rule_collection1"
    priority = 400
    action   = "Deny"
    rule {
      name                  = "network_rule_collection1_rule1"
      protocols             = ["TCP", "UDP"]
      source_addresses      = ["10.0.0.5-10.0.0.7"]
      destination_addresses = ["192.168.1.1-192.168.1.2"]
      destination_ports     = ["80", "1000-2000"]
    }
  }
}

Debug Output/Panic Output

Error: expected network_rule_collection.0.rule.15.source_addresses.0 to contain a valid IP, got: 10.0.0.5-10.0.0.7

Expected Behaviour

"source_addresses" should work the same as "destination_addresses", which allows for ip ranges with hyphens...

Actual Behaviour

Error: expected network_rule_collection.0.rule.15.source_addresses.0 to contain a valid IP, got: 10.0.0.5-10.0.0.7

Steps to Reproduce

terraform plan / terraform apply

(This bug only affects the 'source_addresses' field, ip ranges with hyphens works fine in 'destination_addresses'.(ip ranges with hyphens are valid in azure firewall policy network rules))

Important Factoids

No response

References

No response

@github-actions
Copy link

This functionality has been released in v3.54.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants