-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource : azurerm_storage_mover_project
#21477
New Resource : azurerm_storage_mover_project
#21477
Conversation
a8c25e8
to
07f330e
Compare
07f330e
to
2dde72b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sinbai, this PR looks good! Just need another nil check and a simplified way to set a variable. Once those and the merge conflicts are fixed, we'll be good to go!
} | ||
|
||
if metadata.ResourceData.HasChange("description") { | ||
properties.Properties.Description = &model.Description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
properties.Properties
could be nil so we need to check that it isn't before trying to set properties.Properties.Description
.
properties.Properties.Description = &model.Description
to
properties.Properties.Description = pointer.To(model.Description)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
|
||
if resp.Model != nil { | ||
if properties := resp.Model.Properties; properties != nil { | ||
if properties.Description != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This if block can be replaced with
if properties.Description != nil { | |
state.Description = pointer.From(properties.Description) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
2dde72b
to
0b87a5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for those changes @sinbai
This functionality has been released in v3.54.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Swagger: https://github.com/Azure/azure-rest-api-specs/blob/add28efcd3a5fd422285d992fb1ec5ee5a7a40a6/specification/storagemover/resource-manager/Microsoft.StorageMover/stable/2023-03-01/storagemover.json#L916
Test Results: