Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_monitor_metric_alert - fix crash when dynamic_criteria.0.ignore_data_before isn't set #21446

Merged
merged 4 commits into from
Apr 18, 2023

Conversation

teowa
Copy link
Contributor

@teowa teowa commented Apr 18, 2023

resolves #21445

TF_ACC=1 go test -v ./internal/services/monitor -parallel 20 -test.run=TestAccMonitorMetricAlert_dyna -timeout 1440m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccMonitorMetricAlert_dynamicCriteria
=== PAUSE TestAccMonitorMetricAlert_dynamicCriteria
=== CONT  TestAccMonitorMetricAlert_dynamicCriteria
--- PASS: TestAccMonitorMetricAlert_dynamicCriteria (389.53s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/monitor       389.579s

@github-actions github-actions bot added size/M and removed size/XS labels Apr 18, 2023
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry changed the title azurerm_monitor_metric_alert - fix dynamic_criteria.ignore_data_before to avoid crash azurerm_monitor_metric_alert - fix crash when dynamic_criteria.0.ignore_data_before isn't set Apr 18, 2023
@mbfrahry mbfrahry added this to the v3.53.0 milestone Apr 18, 2023
@mbfrahry mbfrahry merged commit 070744f into hashicorp:main Apr 18, 2023
mbfrahry added a commit that referenced this pull request Apr 18, 2023
@github-actions
Copy link

This functionality has been released in v3.53.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Jun 2, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_monitor_metric_alert Error with 3.52.0 when setting dynamic_criteria
2 participants