Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: updating monitor to use hashicorp/go-azure-sdk #21392

Merged
merged 9 commits into from
Apr 13, 2023

Conversation

catriona-m
Copy link
Member

No description provided.

@catriona-m catriona-m requested a review from a team April 12, 2023 16:07
@jackofallops
Copy link
Member

Hi @catriona-m - We have a new test failure:

=== CONT  TestAccMonitorMetricAlert_multiCriteria
testcase.go:110: Step 1/2 error: Error running pre-apply refresh: exit status 1
Error: expected criteria.0.operator to be one of [Equals GreaterThan GreaterThanOrEqual LessThan LessThanOrEqual], got NotEquals
with azurerm_monitor_metric_alert.test,
on terraform_plugin_test.tf line 45, in resource "azurerm_monitor_metric_alert" "test":
45:     operator               = "NotEquals"
--- FAIL: TestAccMonitorMetricAlert_multiCriteria (3.53s)
FAIL

Could you look into it? (seems to be a missing enum here )

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @catriona-m - LGTM 👍

string(insights.OperatorGreaterThanOrEqual),
string(insights.OperatorLessThan),
string(insights.OperatorLessThanOrEqual),
string(insights.OperatorNotEquals),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting here for posterity: Discussed that this is not a breaking change as the value is rejected by the API and not present in the OpenAPI spec.

@jackofallops jackofallops merged commit 3c43a26 into main Apr 13, 2023
@jackofallops jackofallops deleted the cm/monitorsdk branch April 13, 2023 12:42
@github-actions github-actions bot added this to the v3.52.0 milestone Apr 13, 2023
jackofallops added a commit that referenced this pull request Apr 13, 2023
@github-actions
Copy link

This functionality has been released in v3.52.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants