Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_storage_account_local_user - Supports updating ssh_authorized_key #21362

Merged
merged 2 commits into from
Apr 12, 2023
Merged

azurerm_storage_account_local_user - Supports updating ssh_authorized_key #21362

merged 2 commits into from
Apr 12, 2023

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Apr 11, 2023

Fix #21333

Test

💢  TF_ACC=1 go test -v -timeout=20h -run='TestAccLocalUser_sshKeyOnly$' ./internal/services/storage
=== RUN   TestAccLocalUser_sshKeyOnly
=== PAUSE TestAccLocalUser_sshKeyOnly
=== CONT  TestAccLocalUser_sshKeyOnly
--- PASS: TestAccLocalUser_sshKeyOnly (230.48s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/storage       230.494s

jackofallops
jackofallops approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @magodo - this LGTM 👍

@jackofallops
Copy link
Member

Tests look good

image

@jackofallops jackofallops merged commit 18909bd into hashicorp:main Apr 12, 2023
@github-actions github-actions bot added this to the v3.52.0 milestone Apr 12, 2023
jackofallops added a commit that referenced this pull request Apr 12, 2023
@jackofallops
update for #21362
80179f6
@github-actions
Copy link

This functionality has been released in v3.52.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackofallops jackofallops jackofallops approved these changes

Assignees
No one assigned
Labels
documentation enhancement service/storage size/S
Projects
None yet
Milestone
v3.52.0
Development

Successfully merging this pull request may close these issues.

Support for not recreating azurerm_storage_account_local_user when we add an ssh_authorized_key
2 participants
@magodo @jackofallops