advisor: refactoring to use hashicorp/go-azure-sdk

[katbyte]

No description provided.

[stephybun]

Thanks @katbyte, got a test failure though

------- Stdout: -------
=== RUN   TestAccAdvisorRecommendationsDataSource_basic
=== PAUSE TestAccAdvisorRecommendationsDataSource_basic
=== CONT  TestAccAdvisorRecommendationsDataSource_basic
testcase.go:110: Step 1/1 error: Error running pre-apply refresh: exit status 1
Error: loading Advisor Recommendation for "Subscription (Subscription: \"*******\")": loading the initial page: getrecommendations.GetRecommendationsClient#RecommendationsList: Failure responding to request: StatusCode=400 -- Original Error: autorest/azure: error response cannot be parsed: {"" '\x00' '\x00'} error: EOF
with data.azurerm_advisor_recommendations.test,
on terraform_plugin_test.tf line 16, in data "azurerm_advisor_recommendations" "test":
16: data "azurerm_advisor_recommendations" "test" {}
--- FAIL: TestAccAdvisorRecommendationsDataSource_basic (7.09s)
FAIL

[mbfrahry]

Fixed the test and LGTM!

[github-actions]

This functionality has been released in v3.53.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.