Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_netapp_volume_group_sap_hana #21290

Merged
merged 89 commits into from
Apr 26, 2023

Conversation

paulomarquesc
Copy link
Contributor

This PR implements support for a feature called Application Volume Group for SAP-HANA.

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So close! Final bits is just more testing!

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry one more review to get one more test added

@paulomarquesc paulomarquesc requested a review from mbfrahry April 25, 2023 14:24
@mbfrahry mbfrahry changed the title Application Volume Group for SAP-HANA Implementation New Resource: azurerm_netapp_volume_group_sap_hana Apr 26, 2023
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry merged commit 7001c36 into hashicorp:main Apr 26, 2023
@mbfrahry mbfrahry deleted the pmarques/new_avg_feature branch April 26, 2023 18:28
@github-actions github-actions bot added this to the v3.54.0 milestone Apr 26, 2023
mbfrahry added a commit that referenced this pull request Apr 26, 2023
tombuildsstuff pushed a commit that referenced this pull request Apr 27, 2023
@github-actions
Copy link

This functionality has been released in v3.54.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Jun 1, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants