azurerm_virtual_network_gateway: Add OpenVPN as a client protocol option

[maetthu]

This patch allows setting OpenVPN as a VPN Gateway client protocol (currently in Public Preview).

Annoucement: https://azure.microsoft.com/en-us/updates/openvpn-support-for-azure-vpn-gateways/
Docs: https://docs.microsoft.com/en-us/azure/vpn-gateway/vpn-gateway-howto-openvpn

[katbyte]

Hi @maetthu,

Thank you for the PR. It LGTM aside from there being no test. Could we add this to an existing test? Once thats done I look forward to getting this merged for you 🙂

[maetthu]

@katbyte I didn't add it to the test because it will fail unless you'll opt in your Azure subscription for the preview. But if this isn't an issue, then sure, I'll add it of course 🙂

[katbyte]

Thanks, I've enabled it in our test subscription so it'll pass for us.

[maetthu]

@katbyte done 🙂

[katbyte]

@maetthu,

It looks like you'll need to add a new test:

* azurerm_virtual_network_gateway.test: Error Creating/Updating AzureRM Virtual Network Gateway "acctestvng-2114873327258535664" (Resource Group "acctestRG-2114873327258535664"): network.VirtualNetworkGatewaysClient#CreateOrUpdate: Failure sending request: StatusCode=0 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="VpnClientOpenVpnProtocolCannotCoexist" Message="Vpn client protocol OpenVPN cannot coexist with other vpn client protocols." Details=[]

[maetthu]

@katbyte Oh, sorry, I wasn't aware the OpenVPN option is exclusive.

I've now added a separate test case for setting OpenVPN:

$ TESTARGS="-run TestAccAzureRMVirtualNetworkGateway_vpnClientConfigOpenVPN" make testacc                                                 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccAzureRMVirtualNetworkGateway_vpnClientConfigOpenVPN -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
?       github.com/terraform-providers/terraform-provider-azurerm       [no test files]
=== RUN   TestAccAzureRMVirtualNetworkGateway_vpnClientConfigOpenVPN
--- PASS: TestAccAzureRMVirtualNetworkGateway_vpnClientConfigOpenVPN (1930.51s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm       1930.522s

[tombuildsstuff]

hey @maetthu

Thanks for pushing those changes - there's one minor fix needed here to make this consistent - but this otherwise LGTM 👍

Thanks!

[katbyte]

LGTM now too 👍

[katbyte]

confirm test passes:

==> Fixing source code with gofmt...
gofmt -s -w ./azurerm
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./azurerm -v -test.run=TestAccAzureRMVirtualNetworkGateway_vpnClientConfigOpenVPN -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMVirtualNetworkGateway_vpnClientConfigOpenVPN
--- PASS: TestAccAzureRMVirtualNetworkGateway_vpnClientConfigOpenVPN (1481.05s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	1481.082s

[maetthu]

cool, thx!

[tombuildsstuff]

hi @maetthu

Just to let you know that this has been released as a part of v1.18 of the AzureRM Provider (the full changelog is available here). You can upgrade to this by specifying the version in the provider block (as shown below) and then running terraform init -upgrade

provider "azurerm" {
  version = "=1.18.0"
}

Thanks!

[maetthu]

@tombuildsstuff very nice, thank you 🙂

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!