Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_automation_software_update_configuration: add default definition in software update #21254

Merged
merged 2 commits into from
Apr 3, 2023

Conversation

wuxu92
Copy link
Contributor

@wuxu92 wuxu92 commented Apr 3, 2023

resolves: #21180 .

the document has mark this field Defaults to 'Etc/UTC' already.

--- PASS: TestAccSoftwareUpdateConfiguration_defaultTimeZone (297.21s)
PASS

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @wuxu92.

I checked the docs and it says the default is UTC but it should be updated to reflect the actual default value which is now Etc/UTC.

Also did this use to work/did the API change the default value from UTC to Etc/UTC? Could this change break users that have provisioned this resource using an older API version?

@wuxu92
Copy link
Contributor Author

wuxu92 commented Apr 3, 2023

@stephybun sorry i forgot to update the document. and i find that the automation_schedule resource's timezone in document also not updated. so i updated this PR to fix the document too.

change information from release log as below. the software_udpate_configuration resource was introduced after v3.24, so i believe this PR should not cause any breaking change.

The default value for the field `timezone` will be changed from `UTC` to `Etc/UTC`.

@stephybun stephybun added the bug label Apr 3, 2023
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wuxu92 LGTM 🌺

@stephybun stephybun merged commit e625d09 into hashicorp:main Apr 3, 2023
@github-actions github-actions bot added this to the v3.51.0 milestone Apr 3, 2023
stephybun added a commit that referenced this pull request Apr 3, 2023
@wuxu92 wuxu92 deleted the softup/tz branch April 3, 2023 12:41
@github-actions
Copy link

This functionality has been released in v3.51.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_automation_software_update_configuration | time_zone Id is not valid
2 participants