Fix dependency parse of azurerm_kusto_cluster.id

[myc2h6o]

Fix #20868
The segment Clusters in id of azurerm_kusto_cluster has been changed to clusters in #19525. For other resources which has kusto cluster as part of its dependency created in older provider version, the segment is already set to Clusters at service side. This could cause a diff when provider is updated, where azurerm_kusto_cluster.id is auto migrated to clusters in the state updater, while it's still Clusters at service side. Fixing the diff by normalize the ID returned by service.

[katbyte]

i'm not sure why this is a function as its only used in a single place? can we inline it?

[myc2h6o]

done.

[stephybun]

Thanks for this @myc2h6o, one minor comment but otherwise this is looking good.

[stephybun]

This can probably be simplified to

Suggested change

	if strings.Contains(strings.ToLower(id.ResourceUri), "microsoft.kusto/clusters/") {
	if v, err := kustoParse.ClusterIDInsensitively(id.ResourceUri); err == nil {
	id.ResourceUri = v.ID()
	}
	}
	if v, err := kustoParse.ClusterIDInsensitively(id.ResourceUri); err == nil {
	id.ResourceUri = v.ID()
	}

[myc2h6o]

done.

[stephybun]

Thanks @myc2h6o LGTM 💯

[github-actions]

This functionality has been released in v3.51.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[esener303]

I faced same issue but related to different service like azurerm_synapse_managed_private_endpoint and on server side there its Microsoft.Kusto/Clusters which was created by old provider version, after upgrade to 3.51.0 same issue persist and can not find any solution and workarounds so far.

 # module.plantlink_standalone_adx_cluster.azurerm_synapse_managed_private_endpoint.synapse_adx_endpoint must be replaced
-/+ resource "azurerm_synapse_managed_private_endpoint" "synapse_adx_endpoint" {
      ~ id                   = "/subscriptions/xxx-xxx-xxx-xxx/resourceGroups/rg-emea_we_hcpdev-plantlink_workspace_001/providers/Microsoft.Synapse/workspaces/plsynw-emea-we-hcpdev-plantlinksw-dev-001/managedVirtualNetworks/default/managedPrivateEndpoints/kustoplantlinkdev" -> (known after apply)
        name                 = "kustoplantlinkdev"
      ~ target_resource_id   = "/subscriptions/xxx-xxx-xxx-xxx/resourceGroups/rg-emea_we_hcpdev-plantlink_dev_001/providers/Microsoft.Kusto/Clusters/kustoplantlinkdev" -> "/subscriptions/xxx-xxx-xxx-xxx/resourceGroups/rg-emea_we_hcpdev-plantlink_dev_001/providers/Microsoft.Kusto/clusters/kustoplantlinkdev"

Seems like issue was solved only on 'services/monitor/monitor_diagnostic_setting_resource' not globally or other services which could relate or referred.

workaround its to use replace function with replace(azurerm_kusto_cluster.cluster.id, "clusters", "Clusters").

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.