Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Source kubernetes_cluster - support for using the data source with limited permissions #21229

Merged
merged 2 commits into from
Apr 4, 2023

Conversation

tombuildsstuff
Copy link
Contributor

This PR does two things:

  1. Refactors the Data Source and Resource for azurerm_kubernetes_cluster to ensure that a value is always set into the state for the kube_admin_config, kube_admin_config_raw, kube_config and kube_config_raw fields, so these can be interpolated correctly.
  2. Data Source: azurerm_kubernetes_cluster: support for working with limited permissions, such as when the ListUserCredentials and ListAdminCredentials APIs can't be called due to permissions.

Supersedes #21209
Fixes #21183

…kube_admin_config_raw` always get a value
@tombuildsstuff tombuildsstuff marked this pull request as ready for review March 31, 2023 11:15
@tombuildsstuff tombuildsstuff force-pushed the b/kubernetes-cluster-permissions branch from 8bf7fa1 to 3218378 Compare March 31, 2023 11:15
@tombuildsstuff tombuildsstuff modified the milestones: Blocked, v3.51.0 Mar 31, 2023
@tombuildsstuff tombuildsstuff requested a review from a team March 31, 2023 11:15
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tombuildsstuff - LGTM 👍

@stephybun stephybun merged commit 8d5e24d into main Apr 4, 2023
@stephybun stephybun deleted the b/kubernetes-cluster-permissions branch April 4, 2023 14:08
stephybun added a commit that referenced this pull request Apr 4, 2023
@github-actions
Copy link

This functionality has been released in v3.51.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetching AKS Cluster credentials unfortunately does still not work. PR #20927 did NOT solve the issue
3 participants