azurerm_web_pubsub_hub - add event_listener property
#21145
Conversation
|
|
||
| * `system_event_name_filter` - (Optional) Specify the list of system events. Supported values are `connect`, `connected` and `disconnected`. | ||
|
|
||
| * `user_event_name_filter` - (Optional) Specify the matching event names. There are 3 kind of patterns supported: * `*` matches any event name * `,` Combine multiple events with `,` for example `event1,event2`, it matches event `event1` and `event2` * The single event name, for example `event1`, it matches `event1`. Defaults to `"*"` |
There was a problem hiding this comment.
shouldn't this property be a lint then instead of CSV?
There was a problem hiding this comment.
Thanks kt for the review, sorry that I can't quite follow your question, can you be more specific about it? Thanks
There was a problem hiding this comment.
sorry list. ie as it is * or event1,event2 it could be user_event_name_filter = ["*"] and user_event_name_filter = ['event1","event2"]
|
Thanks Kt for the review, the property is defined as string in api, just like user event pattern in event handler. Are you suggesting that we make it as a list and do the list-string-list conversion in the provider? |
|
@xiaxyi - i understand that is what it is in the API, however that appears to be a string taking a CSV list. so i think it makes sense to define it in terraform as a list and compose the CSV string so users can leverage arrays loops etc in terraform? |
|
Thanks @katbyte for the suggestion, code and document is updated and local test is passed:
|
| Elem: &pluginsdk.Resource{ | ||
| Schema: map[string]*pluginsdk.Schema{ | ||
| "user_event_name_filter": { | ||
| Type: pluginsdk.TypeSet, |
There was a problem hiding this comment.
This probably wants to be a list instead of a set
| Type: pluginsdk.TypeSet, | |
| Type: pluginsdk.TypeList, |
| }, | ||
|
|
||
| "system_event_name_filter": { | ||
| Type: pluginsdk.TypeSet, |
There was a problem hiding this comment.
Same here
| Type: pluginsdk.TypeSet, | |
| Type: pluginsdk.TypeList, |
|
Thanks @stephybun , you are correct, we do need to make the property an ordered list. I changed the type. |
|
Thanks @stephybun , updated the docs. |
|
This functionality has been released in v3.51.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
acc test:
--- PASS: TestAccWebPubsubHub_withMultipleEventListenerSettingsUpdate (2040.01s)
PASS
ok github.com/hashicorp/terraform-provider-azurerm/internal/services/signalr 2040.772s