Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_kubernetes_cluster - fix validation logic for dns_prefix #20813

Merged
merged 4 commits into from
Mar 7, 2023
Merged

azurerm_kubernetes_cluster - fix validation logic for dns_prefix #20813

merged 4 commits into from
Mar 7, 2023

Conversation

WodansSon
Copy link
Collaborator

(fixes #20806)

@WodansSon WodansSon added this to the v3.47.0 milestone Mar 7, 2023
@github-actions github-actions bot added the size/M label Mar 7, 2023
stephybun
stephybun approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @WodansSon. Two minor comments on the error message and property description in the docs, otherwise LGTM 💯

@WodansSon
Copy link
Collaborator Author

image

@WodansSon WodansSon merged commit 9e546c5 into main Mar 7, 2023
@WodansSon WodansSon deleted the b_aks_dnsprefix branch March 7, 2023 19:23
WodansSon added a commit that referenced this pull request Mar 7, 2023
@WodansSon
updating to include #20813
6b09681
@github-actions
Copy link

This functionality has been released in v3.47.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephybun stephybun stephybun approved these changes

Assignees
No one assigned
Labels
documentation service/kubernetes-cluster size/M
Projects
None yet
Milestone
v3.47.0
Development

Successfully merging this pull request may close these issues.

AKS cluster fails to provision where dns_prefix has leading digit
2 participants
@WodansSon @stephybun