Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_sentinel_metadata #20801

Merged
merged 4 commits into from
Mar 7, 2023

Conversation

ziyeqf
Copy link
Contributor

@ziyeqf ziyeqf commented Mar 6, 2023

dependency is a special block which allows recursion, so it's in json format.

test

terraform-provider-azurerm ❯ TF_ACC=1 go test -v ./internal/services/sentinel -run=TestAccMetadata -timeout=600m                   terraform-provider-azurerm [ tengzh/vanguard/sentinel/metadata][$][🐹 v1.20.1][⏱ 4m14s][18:23:07]❯ 
=== RUN   TestAccMetadata_basic
=== PAUSE TestAccMetadata_basic
=== RUN   TestAccMetadata_complete
=== PAUSE TestAccMetadata_complete
=== RUN   TestAccMetadata_update
=== PAUSE TestAccMetadata_update
=== CONT  TestAccMetadata_basic
=== CONT  TestAccMetadata_update
=== CONT  TestAccMetadata_complete
--- PASS: TestAccMetadata_basic (299.41s)
--- PASS: TestAccMetadata_complete (301.13s)
--- PASS: TestAccMetadata_update (396.49s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/sentinel      397.719s

an extra one for "solution"

terraform-provider-azurerm ❯  TF_ACC=1 go test -v ./internal/services/sentinel -run=TestAccMetadata_completeWithSolution -timeout=600m
=== RUN   TestAccMetadata_completeWithSolution
=== PAUSE TestAccMetadata_completeWithSolution
=== CONT  TestAccMetadata_completeWithSolution
--- PASS: TestAccMetadata_completeWithSolution (300.50s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/sentinel      301.704s

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌵

@katbyte katbyte merged commit c9e93b9 into hashicorp:main Mar 7, 2023
@github-actions github-actions bot added this to the v3.47.0 milestone Mar 7, 2023
katbyte added a commit that referenced this pull request Mar 7, 2023
Comment on lines +294 to +309
"Reconnaissance",
"ResourceDevelopment",
"InitialAccess",
"Execution",
"Persistence",
"PrivilegeEscalation",
"DefenseEvasion",
"CredentialAccess",
"Discovery",
"LateralMovement",
"Collection",
"CommandAndControl",
"Exfiltration",
"Impact",
"ImpairProcessControl",
"InhibitResponseFunction",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ziyeqf is there a Swagger source for these?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, it comes from service validation rule.. just opened an issue requesting for it.Azure/azure-rest-api-specs#22956

jackofallops pushed a commit to xiaxyi/terraform-provider-azurerm that referenced this pull request Mar 7, 2023
jackofallops pushed a commit to xiaxyi/terraform-provider-azurerm that referenced this pull request Mar 7, 2023
@github-actions
Copy link

This functionality has been released in v3.47.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants