Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data.azurerm_redis_cache : fix issue about schedules could not be found when no patch_schedule is specified in creation #20516

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

sinbai
Copy link
Contributor

@sinbai sinbai commented Feb 17, 2023

Since patch_schedule is an optional property, "patchSchedulesClient.Get " could not find the schedule when patch_schedule is not specified in creation. Submitted this PR to fix issue #20489 by only setting patch_schedule if the schedule exists.

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry merged commit ccddd23 into hashicorp:main Feb 17, 2023
@mbfrahry mbfrahry added this to the v3.45.0 milestone Feb 17, 2023
mbfrahry added a commit that referenced this pull request Feb 17, 2023
@github-actions
Copy link

This functionality has been released in v3.45.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2023
@sinbai sinbai deleted the redis/fix_issue_20489 branch March 28, 2024 02:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_redis_cache no patch schedules found for redis cache
2 participants