New Resource:azurerm_site_recovery_hyperv_replication_policy

[ziyeqf]

test

terraform-provider-azurerm ❯ TF_ACC=1 go test -v ./internal/services/recoveryservices -run=TestAccSiteRecoveryReplicationPolicyHyperV_ -timeout=600m
=== RUN   TestAccSiteRecoveryReplicationPolicyHyperV_basic
=== PAUSE TestAccSiteRecoveryReplicationPolicyHyperV_basic
=== RUN   TestAccSiteRecoveryReplicationPolicyHyperV_noSnapshots
=== PAUSE TestAccSiteRecoveryReplicationPolicyHyperV_noSnapshots
=== CONT  TestAccSiteRecoveryReplicationPolicyHyperV_basic
=== CONT  TestAccSiteRecoveryReplicationPolicyHyperV_noSnapshots
--- PASS: TestAccSiteRecoveryReplicationPolicyHyperV_noSnapshots (481.83s)
--- PASS: TestAccSiteRecoveryReplicationPolicyHyperV_basic (492.59s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/recoveryservices      493.819s

[stephybun]

Thanks @ziyeqf, left some comments in-line, once those are fixed up we can have another look and get this merged!

[katbyte]

Test are failing..

------- Stdout: -------
=== RUN   TestAccSiteRecoveryReplicationPolicyHyperV_basic
=== PAUSE TestAccSiteRecoveryReplicationPolicyHyperV_basic
=== CONT  TestAccSiteRecoveryReplicationPolicyHyperV_basic
    testcase.go:110: Step 1/2 error: Error running pre-apply refresh: exit status 1
        
        Error: Missing required argument
        
          on terraform_plugin_test.tf line 31, in resource "azurerm_site_recovery_hyperv_replication_policy" "test":
          31: resource "azurerm_site_recovery_hyperv_replication_policy" "test" {
        
        The argument "recovery_vault_id" is required, but no definition was found.
        
        Error: Unsupported argument
        
          on terraform_plugin_test.tf line 32, in resource "azurerm_site_recovery_hyperv_replication_policy" "test":
          32:   resource_group_name                                = azurerm_resource_group.test.name
        
        An argument named "resource_group_name" is not expected here.
        
        Error: Unsupported argument
        
          on terraform_plugin_test.tf line 33, in resource "azurerm_site_recovery_hyperv_replication_policy" "test":
          33:   recovery_vault_name                                = azurerm_recovery_services_vault.test.name
        
        An argument named "recovery_vault_name" is not expected here.
--- FAIL: TestAccSiteRecoveryReplicationPolicyHyperV_basic (2.37s)
FAIL

[ziyeqf]

@katbyte sorry for that, forgot to update test case...

test after udpate:

terraform-provider-azurerm ❯ TF_ACC=1 go test -v ./internal/services/recoveryservices -run=TestAccSiteRecoveryReplicationPolicyHyperV_ -timeout=600m                 [ tengzh/recovery/hyperv/policy][$][🐹 v1.19.5][⏱ 1m1s][11:21:20]
=== RUN   TestAccSiteRecoveryReplicationPolicyHyperV_basic
=== PAUSE TestAccSiteRecoveryReplicationPolicyHyperV_basic
=== RUN   TestAccSiteRecoveryReplicationPolicyHyperV_noSnapshots
=== PAUSE TestAccSiteRecoveryReplicationPolicyHyperV_noSnapshots
=== CONT  TestAccSiteRecoveryReplicationPolicyHyperV_basic
=== CONT  TestAccSiteRecoveryReplicationPolicyHyperV_noSnapshots
--- PASS: TestAccSiteRecoveryReplicationPolicyHyperV_noSnapshots (474.58s)
--- PASS: TestAccSiteRecoveryReplicationPolicyHyperV_basic (475.15s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/recoveryservices      476.410s

[stephybun]

Thanks @ziyeqf LGTM 🍀

[github-actions]

This functionality has been released in v3.45.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.