Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_monitor_aad_diagnostic_setting - parse log_analytics_workspace_id insensitively in Read #20206

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

myc2h6o
Copy link
Contributor

@myc2h6o myc2h6o commented Jan 28, 2023

Using Parse...IDInsensitively so that possible casing change at server side won't cause a failure. In Read(), the value is captured and parsed then set to log_analytics_workspace_id, which has ValidateFunc: workspaces.ValidateWorkspaceID in schema to validate the value in config, so normalizing it shall not cause a diff.

@tombuildsstuff tombuildsstuff added this to the v3.42.0 milestone Jan 30, 2023
@tombuildsstuff tombuildsstuff merged commit b354a23 into hashicorp:main Jan 30, 2023
tombuildsstuff added a commit that referenced this pull request Jan 30, 2023
@myc2h6o myc2h6o deleted the draft_read_casing branch January 31, 2023 04:08
@github-actions
Copy link

github-actions bot commented Feb 3, 2023

This functionality has been released in v3.42.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Mar 6, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants