azurerm_storage_object_replication - Use storage account id as properties.sourceAccount and properties.destinationAccount

[magodo]

Detailed context of this change can be found at: #19457 (comment). Quoted below:

Per: https://learn.microsoft.com/en-us/azure/storage/blobs/object-replication-overview#specify-full-resource-ids-for-the-source-and-destination-accounts

The policy definition file previously required only the account name, instead of the full resource ID for the storage account. With the introduction of the AllowCrossTenantReplication security property in version 2021-02-01 of the Azure Storage resource provider REST API, you must now provide the full resource ID for any object replication policies that are created when cross-tenant replication is disallowed for a storage account that participates in the replication policy. Azure Storage uses the full resource ID to verify whether the source and destination accounts reside within the same tenant.

The ARM API-endpoint docs have also been updated: https://learn.microsoft.com/en-us/rest/api/storagerp/object-replication-policies/get?tabs=HTTP#objectreplicationpolicy

properties.destinationAccount - Required. Destination account name. It should be full resource id if allowCrossTenantReplication set to false.
properties.sourceAccount - Required. Source account name. It should be full resource id if allowCrossTenantReplication set to false.

Fix #19457

Note that since the terraform schema is always using the storage account id before and after this PR, which means there would be no impact to existing users. As we are not reading the properties.sourceAccount and properties.destinationAccount to construct our TF state, but only used for import check (hence the change).

Test

>  TF_ACC=1 go test -v -timeout=20h ./internal/services/storage -run=TestAccStorageObjectReplication_
=== RUN   TestAccStorageObjectReplication_basic
=== PAUSE TestAccStorageObjectReplication_basic
=== RUN   TestAccStorageObjectReplication_requiresImport
=== PAUSE TestAccStorageObjectReplication_requiresImport
=== RUN   TestAccStorageObjectReplication_complete
=== PAUSE TestAccStorageObjectReplication_complete
=== RUN   TestAccStorageObjectReplication_update
=== PAUSE TestAccStorageObjectReplication_update
=== RUN   TestAccStorageObjectReplication_crossTenantDisabled
=== PAUSE TestAccStorageObjectReplication_crossTenantDisabled
=== RUN   TestAccStorageObjectReplication_crossSubscription
=== PAUSE TestAccStorageObjectReplication_crossSubscription
=== CONT  TestAccStorageObjectReplication_crossSubscription
=== CONT  TestAccStorageObjectReplication_basic
=== CONT  TestAccStorageObjectReplication_update
=== CONT  TestAccStorageObjectReplication_crossTenantDisabled
=== CONT  TestAccStorageObjectReplication_complete
=== CONT  TestAccStorageObjectReplication_requiresImport
--- PASS: TestAccStorageObjectReplication_crossTenantDisabled (180.06s)
--- PASS: TestAccStorageObjectReplication_complete (181.58s)
--- PASS: TestAccStorageObjectReplication_basic (183.65s)
--- PASS: TestAccStorageObjectReplication_requiresImport (187.35s)
--- PASS: TestAccStorageObjectReplication_crossSubscription (206.38s)
--- PASS: TestAccStorageObjectReplication_update (371.12s)
PASS

[katbyte]

@magodo - can we fix the conflic and build?

[katbyte]

Thanks @magodo - LGTM 🥤

[github-actions]

This functionality has been released in v3.46.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.