Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_cdn_frontdoor_origin_group - hack SDK to allow health_probe to be passed as null #20015

Merged
merged 2 commits into from
Jan 18, 2023
Merged

azurerm_cdn_frontdoor_origin_group - hack SDK to allow health_probe to be passed as null #20015

merged 2 commits into from
Jan 18, 2023

Conversation

WodansSon
Copy link
Collaborator

(fixes #19585)

@WodansSon WodansSon added bug upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR service/cdn labels Jan 14, 2023
@WodansSon WodansSon added this to the v3.40.0 milestone Jan 14, 2023
@WodansSon
Copy link
Collaborator Author

image

tombuildsstuff
tombuildsstuff approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question but this otherwise LGTM 👍

internal/services/cdn/azuresdkhacks/cdn_frontdoor_origin_group.go
Comment on lines +119 to +121
if ogupp.LoadBalancingSettings != nil {
objectMap["loadBalancingSettings"] = ogupp.LoadBalancingSettings
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

presumably this is also the case for loadBalancingSettings here too?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question, but I do not believe it will be needed for the loadBalancingSettings since it is a required field and has default values for the attributes within the code block. On a side note, it appears that the loadBalincingSettings are mostly used by the Health Probes to evaluate the quickest route to the nearest backend pool. So going out on a limb here, if you disable the health probes the loadBalincingSettings are ignored?

@WodansSon WodansSon merged commit 9f6dba9 into main Jan 18, 2023
@WodansSon WodansSon deleted the b_cdn_frontdoor_og_health branch January 18, 2023 01:53
WodansSon added a commit that referenced this pull request Jan 18, 2023
@WodansSon
Updating to include #20015
316c323
@github-actions
Copy link

This functionality has been released in v3.40.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
bug service/cdn size/L upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR
Projects
None yet
Milestone
v3.40.0
Development

Successfully merging this pull request may close these issues.

azurerm_cdn_frontdoor_origin_group - Health probe can't be removed
2 participants
@WodansSon @tombuildsstuff